Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLA Tunnel unit repair stacks with every additional Tunnel #838

Open
xezon opened this issue Aug 6, 2022 · 7 comments
Open

GLA Tunnel unit repair stacks with every additional Tunnel #838

xezon opened this issue Aug 6, 2022 · 7 comments
Labels
Bug Something is not working right ExecutableMaybe Is perhaps game code related Minor Severity: Minor < Major < Critical < Blocker

Comments

@xezon
Copy link
Collaborator

xezon commented Aug 6, 2022

GLA Tunnel unit repair feels instantaneous. Is this too strong?

TimeForFullHeal     = 5000   ;(in milliseconds)

Value indicates it takes 5 seconds to heal.

@xezon xezon added Design Is a matter of game design Controversial Is controversial labels Aug 6, 2022
@xezon xezon changed the title GLA Tunnel unit repair feels instantaneously GLA Tunnel unit repair feels instantaneous Aug 6, 2022
@ThePredatorBG
Copy link
Collaborator

ThePredatorBG commented Aug 6, 2022

Having a Sneak Attack reduces the time taken for full heal, which is probably a bug. It should be taken into account.

@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Aug 9, 2022
@xezon
Copy link
Collaborator Author

xezon commented Aug 12, 2022

GLA Tunnel was tested. It works as advertised. All TimeForFullHeal in TunnelContain have value 5000. There is nothing to be done here.

gla_tunnel.mp4

@xezon xezon closed this as completed Aug 12, 2022
@ImTimK
Copy link
Collaborator

ImTimK commented Aug 12, 2022

GLA Tunnel was tested. It works as advertised. All TimeForFullHeal in TunnelContain have value 5000. There is nothing to be done here.
gla_tunnel.mp4

Tested with Sneak Attack aswell like ThePredatorBG suggested?

And yea it seems fine, not as instant as I thought, weird how it's not that noticable in actual games. Not a fan of increasing the value either, prefer the "buffstuff" approach :D

@xezon
Copy link
Collaborator Author

xezon commented Aug 12, 2022

Ok. I tested with multiple tunnels. With 2 tunnels repair time seems twice or so as fast. With 5 tunnels it is almost instant. Looks like something is wrong.

tunnel_repair_2.mp4

@xezon xezon reopened this Aug 12, 2022
@xezon xezon added Bug Something is not working right ExecutableMaybe Is perhaps game code related and removed Design Is a matter of game design Controversial Is controversial labels Aug 12, 2022
@ImTimK
Copy link
Collaborator

ImTimK commented Aug 12, 2022

:o

It's like all tunnels apply healing to your units at once?

I'm sure that wasn't intended then yea.

@xezon
Copy link
Collaborator Author

xezon commented Aug 12, 2022

Could we possibly spawn 1 unique Dummy Object with TunnelContain that does the Healing just once?

@commy2
Copy link
Collaborator

commy2 commented Aug 12, 2022

Then units wouldn't be killed once the last Tunnel is killed / pop out if the last Tunnel is being sold.

@xezon xezon changed the title GLA Tunnel unit repair feels instantaneous GLA Tunnel unit repair stacks with every additional Tunnel Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right ExecutableMaybe Is perhaps game code related Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

No branches or pull requests

4 participants