Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply stashes have damage effects but don't take any damage #35

Closed
xezon opened this issue Aug 24, 2021 · 7 comments · Fixed by #883
Closed

Supply stashes have damage effects but don't take any damage #35

xezon opened this issue Aug 24, 2021 · 7 comments · Fixed by #883
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker

Comments

@xezon
Copy link
Collaborator

xezon commented Aug 24, 2021

Supply stashes should not have damage effects.

@xezon xezon added the Bug Something is not working right label Aug 24, 2021
@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Sep 17, 2021
@commy2 commy2 self-assigned this Aug 11, 2022
@commy2
Copy link
Collaborator

commy2 commented Aug 11, 2022

What is meant by damage effects? Sparks when hit? If so, seems fine to me. Maybe making them "UNATTACKABLE" is wanted though, because they can't be killed anyway.

@xezon
Copy link
Collaborator Author

xezon commented Aug 12, 2022

When shooting stash it looks and sounds as if structure is attacked. I suspect it should look like attacking Terrain if they cannot be destroyed.

@commy2
Copy link
Collaborator

commy2 commented Aug 12, 2022

Can you elaborate? When I tried doing that, my RPG missiles would phase right through the building and only hit the ground below the Supply.

@xezon
Copy link
Collaborator Author

xezon commented Aug 13, 2022

Video

supply_stash_attacked.mp4

@commy2
Copy link
Collaborator

commy2 commented Aug 13, 2022

I don't see it. That explosion noise is from the Tank Hunter rockets. When they fire in synch, they destroy each other (doesn't change damage, projectile keeps flying).

@xezon
Copy link
Collaborator Author

xezon commented Aug 13, 2022

I think the main concern is the audio. Check again. There is very distinct difference.

@commy2
Copy link
Collaborator

commy2 commented Aug 13, 2022

Ah, yeah, that is a different noise from what I was thinking of:

MSD.mp4

The issue is StructureDamageFXNoShake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
2 participants