Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEED_UPGRADE is messing up stolen or transfered unit weapons #2435

Open
BKRFTTK opened this issue Jun 26, 2024 · 2 comments
Open

NEED_UPGRADE is messing up stolen or transfered unit weapons #2435

BKRFTTK opened this issue Jun 26, 2024 · 2 comments
Labels
Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction

Comments

@BKRFTTK
Copy link

BKRFTTK commented Jun 26, 2024

For Command Buttons, the NEED_UPGRADE option is used to prevent selecting that button until the required upgrade is researched. Due to this, another player that gains control of a unit with one of these buttons won't have access to it until that player researches the upgrade also.

Command_AmericaRangerSwitchToFlagBangGrenades

Transferred Rangers by script or ally surrender in multiplayer can't switch to Flashbangs but will keep Flashbangs if previous owner selected them and can switch to Machine Guns without restriction. Should be fine to NEED_UPGRADE option due to the default Weapon Set not having a Secondary weapon to switch to in the first place.

Command_AmericaVehicleComancheFireRocketPods

No Rocket Pods if transferred while keeping the visual upgrade. Uses Tertiary after upgrade which it lacks on the default Weapon Set. Should remove the option as well.

Command_ChinaNeutronWarhead

Same situation as Ranger but more scenarios since Nuke Cannons can be Unmanned/Hijacked too. Secondary on upgraded Weapon Set which default lacks. Should remove option for same reasons as Ranger.

Demo_Command_TertiarySuicide

All the Demo units have the Tertiary weapon in their default Weapon Sets, and several already use upgraded Weapon Sets for other purposes.
I just realized these can have the option removed if the Command Button can only be accessed with a Command Set upgrade.

@xezon
Copy link
Collaborator

xezon commented Jun 26, 2024

What happens user facing when NEED_UPGRADE is removed from these weapons?

@BKRFTTK
Copy link
Author

BKRFTTK commented Jun 26, 2024

The only difference would be that upgraded units at the time of acquisition can use those buttons while newly built units would need it. It would be no different than a Humvee or Scorpion Tank being acquired and keeping their upgrades while newly built ones wouldn't have them.

@BKRFTTK BKRFTTK closed this as completed Jun 26, 2024
@BKRFTTK BKRFTTK reopened this Jun 26, 2024
@BKRFTTK BKRFTTK closed this as completed Jun 26, 2024
@BKRFTTK BKRFTTK reopened this Jun 26, 2024
@xezon xezon added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction China Affects China faction labels Jun 27, 2024
@xezon xezon changed the title NEED_UPGRADE messing up Stolen/Transfered unit weapons. NEED_UPGRADE is messing up stolen or transfered unit weapons Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right China Affects China faction Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Development

No branches or pull requests

2 participants