Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use macros to build completions statically #34

Merged

Conversation

lavafroth
Copy link
Contributor

@lavafroth lavafroth commented Nov 18, 2023

I wrote a macro to build both the HxCompletion slices and the map statically. The tradeoff: an HxCompletion has its members changed from String to &'static str.

@ThePrimeagen
Copy link
Owner

sorry that i haven't checked this out. my fault

@ThePrimeagen
Copy link
Owner

could you put a little blurp about why this is a good thing?

@lavafroth
Copy link
Contributor Author

lavafroth commented Nov 30, 2023 via email

@ThePrimeagen
Copy link
Owner

Would you like to resolve the conflicts and we can get this in?

@lavafroth
Copy link
Contributor Author

There, we can merge this now.

Copy link
Collaborator

@MNThomson MNThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kid Sunglasses LGTM

@MNThomson MNThomson merged commit 9cbd8d9 into ThePrimeagen:master Dec 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants