-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harpoon doesn't remember my marks after close #577
Comments
Could it be that you use Git-Worktrees? If so, it's a duplicate of #551 |
I don't use Git-Worktrees. I tested like this:
|
Ok, I can confirm that it's not working and that it is the same behavior as with the Git-Worktrees (tested on 0378a6c) |
I think this bug is due to the startup sequence when a custom key is provided. In Harpoon:new(), Data:new() is called with the default config, which loads an empty list from the hash for cwd. Then that empty list writes over the hash for the custom key when the list is synced. |
I am still geting this bug when using git branch as key for separate list per branch. Commit hash is 0378a6c. Right now I switched on e76cb03 as camerondugan sugessted. |
Just wanted to chime in I'm also having this issue on Windows with a super basic setup (no special list names or anything, just a keymap for |
Just got this too I'm on windows 11 My experience is a little different because it was initially working and i was using my repo just fine the way i had it setup from the first time ever adding jumps to the repo but upon trying to edit the list form my first use in the repo i got the problem described before. Suddenly any new instance of vim would wipe the list, except for one of the pre set files. Now I tried the solution of pinning the e76cb03 commit and it worked for me too |
I get the issue only on commits 3e32576 and later.
Harpoon works just fine while nvim is open, but when I close nvim, it forgets the marks. I'm guessing this commit's hashing thing doesn't work for me.
Temporary solution for users:
Pin your version to e76cb03 in your plugin manager of choice. For lazy, just add
commit = 'e76cb03'
, then run:Lazy sync
. If it doesn't work right away, you can restart nvim and it should work now.The text was updated successfully, but these errors were encountered: