Implemented 5-day forecast #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThePredatorBG Since the JS is slowly starting to grow we need to create an easy to use and scale organization of the code. Create folders and move js
|
rawbirth
reviewed
Aug 30, 2022
script.js
Outdated
Comment on lines
36
to
48
| { | ||
| document.querySelector("#day" + (i+1) + "Min").innerHTML = "Min: " + data.list[i].main.temp_min + "°C"; | ||
| } | ||
| for(i=0;i<5;i++) | ||
| { | ||
| document.querySelector("#day" + (i+1) + "Max").innerHTML = "Max: " + data.list[i].main.temp_max + "°C"; | ||
| } | ||
| for(i=0;i<5;i++) | ||
| { | ||
| document.querySelector("#img" + (i+1)).src = "http://openweathermap.org/img/wn/" + data.list[i].weather[0].icon+"@2x.png"; | ||
| } | ||
| console.log(data); |
There was a problem hiding this comment.
@ThePredatorBG no need to do 3 loops. same can be achieved with a single loop.
Also please remove all console.logs before committing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes little visual adjustments to existing HTML on the "About me" page.
Also includes the changes requested in #5's review.