Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Picker background" and "Picker foreground" texts in the application settings should be swapped #348

Closed
Korb opened this issue Aug 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Korb
Copy link

Korb commented Aug 7, 2024

Describe the bug
The shortcuts installed in the application settings are swapped: the key for "Picker background" activates the eyedropper for Picker foreground, and the key for "Picker foreground" activates the eyedropper for Picker background.

In addition, the color order in the main application window and in the settings should match. If "Foreground color" comes first in the main menu, and "Background color" comes second, then the order in the settings should be the same. It is like this now, only the texts do not match.

Desktop (please complete the following information):

  • OS: Microsoft Windows 10.0.19045.4717
  • Version CCA-Portable-x64-3.5.3

To Reproduce

  1. Launch the application, go to settings, and assign "Picker background" and "Picker foreground".
  2. Close settings, and make sure that the combination assigned to "Picker background" changes the color of "Foreground color", and the key for "Picker foreground" changes "Background color".

Expected behavior
"Picker foreground" → "Foreground color"
"Picker background" → "Background color"

@poorgeek poorgeek added the bug Something isn't working label Aug 9, 2024
@poorgeek poorgeek added this to the Sprint 2024.17 milestone Aug 9, 2024
@Korb
Copy link
Author

Korb commented Aug 28, 2024

@ferllings ferllings closed this as completed in 38b4793 Aug 19, 2024

When is a release with this fix expected?

@ferllings
Copy link
Member

@Korb I'm waiting for another contributer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants