Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Caesar Cipher ruby output shows a right shift, not left shift #29106

Closed
3 tasks done
JeffreyMPrice opened this issue Nov 21, 2024 · 1 comment · Fixed by #29107
Closed
3 tasks done

Ruby: Caesar Cipher ruby output shows a right shift, not left shift #29106

JeffreyMPrice opened this issue Nov 21, 2024 · 1 comment · Fixed by #29107
Assignees

Comments

@JeffreyMPrice
Copy link
Contributor

JeffreyMPrice commented Nov 21, 2024

Checks

Describe your suggestion

In the Wikipedia example on the page it mentions that a Caesar Cipher uses a left shift.

The example from the project page which shows a right shift of 5:

  > caesar_cipher("What a string!", 5)
  => "Bmfy f xywnsl!"

I propose:

  • explicitly state to use a right shift in the project instructions
  • note that the wikipedia article uses a left shift

Path

Ruby / Rails

Lesson Url

https://www.theodinproject.com/lessons/ruby-caesar-cipher

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@JeffreyMPrice
Copy link
Contributor Author

I update the issue to reflect a better fix suggest by @JoshDevHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant