Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundations: Incorrect design image being used for landing page project #28702

Closed
2 of 3 tasks
Eduardo06sp opened this issue Aug 26, 2024 · 6 comments · Fixed by #28706
Closed
2 of 3 tasks

Foundations: Incorrect design image being used for landing page project #28702

Eduardo06sp opened this issue Aug 26, 2024 · 6 comments · Fixed by #28706
Assignees

Comments

@Eduardo06sp
Copy link
Member

Checks

Describe your suggestion

The assignment provides 2 design files, one of which shows you all the styles used for the landing page example:

Download the design images and take a look at what you’re going to be creating here. Image One (Full Design), Image Two (Color and Fonts)

If you click on the link for Image Two (Color and Fonts), then you are taken the the (outdated) image that shows the fonts as keywords instead of numeric values (i.e. as extra-bold instead of 900).

The updated/new image can be found in foundations/html_css/flexbox/project-landing-page/imgs/02.png.
https://github.com/TheOdinProject/curriculum/blob/main/foundations/html_css/flexbox/project-landing-page/imgs/02.png

I would rather have a first-time contributor take this issue on. However, if I notice that no one volunteers, I will probably ask to be assigned after some time.

PR that fixed it last time: #25423

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-landing-page

(Optional) Discord Name

Eduardo06sp

(Optional) Additional Comments

No response

@MaoShizhong
Copy link
Contributor

Oh, interesting...so the new image was added but the second PR needed to change the link never happened. Thanks for digging this up, @Eduardo06sp!

Acceptance criteria

  • The CDN link for the font design image is replaced with a new link to the fixed image.

Please comment below if you'd like to be assigned to this issue. Please do not open a PR unless you've been assigned by a maintainer.

@MaoShizhong MaoShizhong added the Status: Help Wanted This issue can be assigned to other contributors label Aug 26, 2024
@dellaighted
Copy link
Contributor

Hi, I would like to help!

@MaoShizhong MaoShizhong removed the Status: Help Wanted This issue can be assigned to other contributors label Aug 26, 2024
@MaoShizhong
Copy link
Contributor

@dellaighted all yours

@dellaighted
Copy link
Contributor

Acceptance criteria

  • The CDN link for the font design image is replaced with a new link to the fixed image.

I followed the acceptance criteria and fixed the second image. I ran the markdown lint on the project-landing-page.md file, and there was an error that pointed to line 15. I checked it, and it's a note instead of a subsection, so I'm not sure if you want that changed.
image
image

@MaoShizhong
Copy link
Contributor

Since the file you were working on was for a project, you needed to run the lint:project script, which uses the heading structure config for projects which differs from lessons.

All tests pass using the project config 👍

@dellaighted
Copy link
Contributor

Ah silly me! Good to hear the tests passed. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@Eduardo06sp @dellaighted @MaoShizhong and others