Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOP Principles: Change Knowledge Check to questions and amend link in #2 #28632

Closed
3 tasks done
Meltasy opened this issue Aug 14, 2024 · 3 comments · Fixed by #28666
Closed
3 tasks done

OOP Principles: Change Knowledge Check to questions and amend link in #2 #28632

Meltasy opened this issue Aug 14, 2024 · 3 comments · Fixed by #28666
Assignees

Comments

@Meltasy
Copy link
Contributor

Meltasy commented Aug 14, 2024

Checks

Describe your suggestion

The Knowledge Check section states ... "The following questions ...", yet all of them are written as statements. I'd suggest amending them all to be written as questions.

In the Knowledge check, the link in the second question refers to an article not covered / referred to during the lesson: https://medium.com/@cramirez92/s-o-l-i-d-the-first-5-priciples-of-object-oriented-design-with-javascript-790f6ac9b9fa.
Should the link be to the following article? https://duncan-mcardle.medium.com/solid-principle-1-single-responsibility-javascript-5d9ce2c6f4a5

Finally, I find the wording of the 1st assignment very repetitive. Do you think it would read better just to say:

  1. The following article and videos mention the acronym SOLID before going on to talk about Single Responsibility. Single Responsibility is definitely the most relevant of the 5, but feel free to dig into the rest of the SOLID principles if you like.
    1. Read this article about SOLID principle 1: Single responsibility (JavaScript). It simplifies that which is covered in more detail in the the SOLID videos below.
    2. Watch The SOLID Design Principles by WDS to see code examples for each principle.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-oop-principles

(Optional) Discord Name

Meltasy

(Optional) Additional Comments

No response

@KevinMulhern
Copy link
Member

Thanks for the suggestions @Meltasy, those all sounds like good changes to me. I've assigned you.

@Meltasy
Copy link
Contributor Author

Meltasy commented Aug 20, 2024

Thanks, I'll get onto that now :-)

@Meltasy
Copy link
Contributor Author

Meltasy commented Aug 20, 2024

That's done, do let me know if there's anything else. Have a lovely day :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants