Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemini-1.5-pro model configured with gemini-1.0-pro-001 version #85

Closed
1 task
sisbell opened this issue Jun 11, 2024 · 1 comment
Closed
1 task

gemini-1.5-pro model configured with gemini-1.0-pro-001 version #85

sisbell opened this issue Jun 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sisbell
Copy link

sisbell commented Jun 11, 2024

Affected plugin(s)

  • VertexAI

Describe the bug
In the VertexAI plugin (js/plugins/vertexai/src/gemini.ts) gemini-1.5-pro model is configured with the gemini-1.0-pro-001 version. It should be using version gemini-1.5-pro-001

export const gemini15Pro = modelRef({
  name: 'vertexai/gemini-1.5-pro',
  info: {
    label: 'Vertex AI - Gemini 1.5 Pro',
    versions: ['gemini-1.0-pro-001'],
    supports: {
      multiturn: true,
      media: true,
      tools: true,
      systemRole: true,
    },
  },
  configSchema: GeminiConfigSchema,
});

Plugin(s) version:
0.5.2

Genkit version:
0.5.2

@sisbell sisbell added the bug Something isn't working label Jun 11, 2024
@Dabolus
Copy link
Collaborator

Dabolus commented Jun 12, 2024

Hi, thanks for opening the issue. However, this repo contains the community maintained plugins (the ones starting with genkitx-, while the VertexAI plugin is an official Firebase plugin (the ones starting with @genkit-ai/). Anyways, I can confirm the issue is present in the official plugin. I opened a PR here to fix it. I'll close this issue since it's not related to this repo, but feel free to open a new one in the official Genkit repo here if you want to follow up.

@Dabolus Dabolus closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants