Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-continuous edge curve tilts #161

Open
TheDuckCow opened this issue Mar 16, 2024 · 2 comments
Open

Non-continuous edge curve tilts #161

TheDuckCow opened this issue Mar 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@TheDuckCow
Copy link
Owner

We recently implemented #135 which nicely generates additional curves on the edges (and center) of the road. This is useful for CSG or other procedural placement efforts, but this also revealed some issues: The ending tilts of these generate curves are not continuous when compared to neighboring road segments (noting that a set of curves currently is generated once per road segment).

See the example below, where the RoadPoint on the right has been tilted

comparison
@TheDuckCow TheDuckCow added the bug Something isn't working label Mar 16, 2024
@TheDuckCow
Copy link
Owner Author

This was a known issue when we merged the curve generating code, we decided to tackle this in a followup. The main way to avoid this in the meantime is to not tilt roadpoints on axes other than Y. There should not be any continuous curve problems for elevation changes though.

@TheDuckCow TheDuckCow self-assigned this Apr 3, 2024
@TheDuckCow
Copy link
Owner Author

TheDuckCow commented Apr 4, 2024

On a little bit of searching, it comes down to this issue:
godotengine/godot#65634
godotengine/godot#79355

So, there's really not much we can do about this in versions of Godot where it's a problem. We might still not be applying the correct tilt, but it wouldn't be reflected in the CSG follow path nodes anyways. Still, leaving this as an open item so we can review once updated engine builds are out.

@TheDuckCow TheDuckCow added the wontfix This will not be worked on label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant