Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Using StrongName instead #11

Closed

Conversation

Tazer
Copy link

@Tazer Tazer commented Jan 15, 2015

@TheCloudlessSky
Copy link
Owner

Thanks for bringing this to my attention!

I don't want to maintain two separate Nuget releases because it's a hack, confuses people and causes the double-package problem.

Even though I'm personally against strong naming (it should be deprecated all together), what should happen is StackExchange.Redis should not have two separate packages (because it causes problems like this). It forces every library that has a dependency on StackExchange.Redis to also have two separate libraries. If the library wants to support strong naming, it should just be a single library with a frozen assembly version. I'll leave this open and continue the discussion on StackExchange/StackExchange.Redis#146.

@TheCloudlessSky
Copy link
Owner

@Tazer I'm sure you're getting updates on the other issue, but right now without having to rebuild/change any libraries/dependencies, you can do the following in your project.

  1. Right-click on the StackExchange.Redis.StrongName reference in your project(s) and click on Properties.
  2. Change the Aliases to signed (remove global):

image

Because you don't need to use StackExchange.Redis directly when you configure Microsoft.Web.RedisSessionStateProvider, you can change its alias to anything other than global and this allows the project to compile/run. I just tested this with a fresh MVC4 project and it worked perfectly.

@Tazer
Copy link
Author

Tazer commented Jan 15, 2015

Great, Thanks for the update. I did solve it in the meantime with a custom built version with StackExchange.Redis.StrongName as a Reference, But will use your suggestion when I have some time over

@Tazer Tazer closed this Jan 15, 2015
@Tazer
Copy link
Author

Tazer commented Jan 15, 2015

But guess your comment would be great to have in the README.md ? :)

@TheCloudlessSky
Copy link
Owner

Yup - I've added a link back to this PR in the README. Thanks!

@dobryanskyy
Copy link

I have to use strong naming due to policy in my company. To be able to use this library i had to compile sources with my own key(as well as redis lib). Now i will not be able to use updates from this lib('cause they will not appear in my nuget and i'll miss them). Such a pity....

@TheCloudlessSky
Copy link
Owner

@dobryanskyy Your company needs to review it's policy because strong naming is not guaranteed and is not recommended for sandboxing anymore.

If you submit a PR that automatically does the strong naming, I'd be happy to include it for those that need it.

@TheCloudlessSky
Copy link
Owner

@dobryanskyy
Copy link

Yes, I've seen that. I even tried it. But for some reason - it crashed upon working on this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants