From 452e39d75884aaffa99ad633ac062339a77f8eaf Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 16:56:17 -0500 Subject: [PATCH 01/10] (#2434) Integration scenarios don't hardcode platform This sets the platform type according to the platform the test is actually running on. --- src/chocolatey.tests.integration/Scenario.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chocolatey.tests.integration/Scenario.cs b/src/chocolatey.tests.integration/Scenario.cs index 7240da58b5..a19ab5cb11 100644 --- a/src/chocolatey.tests.integration/Scenario.cs +++ b/src/chocolatey.tests.integration/Scenario.cs @@ -121,7 +121,7 @@ private static ChocolateyConfiguration baseline_configuration() // prior commands, so ensure that all items go back to the default values here var config = NUnitSetup.Container.GetInstance(); - config.Information.PlatformType = PlatformType.Windows; + config.Information.PlatformType = Platform.get_platform(); config.Information.IsInteractive = false; config.Information.ChocolateyVersion = "1.2.3"; config.Information.PlatformVersion = new Version(6, 1, 0, 0); From 8d8ef3920ff03bba10b32a20c5d4b194acf62c4d Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 16:59:17 -0500 Subject: [PATCH 02/10] (#2434) FileSystemSpecs exclude broken test on Mono --- .../infrastructure.app/services/FilesServiceSpecs.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/chocolatey.tests.integration/infrastructure.app/services/FilesServiceSpecs.cs b/src/chocolatey.tests.integration/infrastructure.app/services/FilesServiceSpecs.cs index a21529b640..3ecab17ce4 100644 --- a/src/chocolatey.tests.integration/infrastructure.app/services/FilesServiceSpecs.cs +++ b/src/chocolatey.tests.integration/infrastructure.app/services/FilesServiceSpecs.cs @@ -28,6 +28,7 @@ namespace chocolatey.tests.integration.infrastructure.app.services using chocolatey.infrastructure.results; using chocolatey.infrastructure.services; using Moq; + using NUnit.Framework; using Should; public class FilesServiceSpecs @@ -88,6 +89,8 @@ public void should_log_a_warning() } [Fact] + [WindowsOnly] + [Platform(Exclude = "Mono")] public void should_log_a_warning_about_locked_files() { bool lockedFiles = false; From 27fe61c3a2984411656633acb5426cdd7de66662 Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 17:00:02 -0500 Subject: [PATCH 03/10] (#2434) CommandExecutorSpecs exclude broken tests on Mono --- .../infrastructure/commands/CommandExecutorSpecs.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/chocolatey.tests.integration/infrastructure/commands/CommandExecutorSpecs.cs b/src/chocolatey.tests.integration/infrastructure/commands/CommandExecutorSpecs.cs index acce153d8c..915cbb7c60 100644 --- a/src/chocolatey.tests.integration/infrastructure/commands/CommandExecutorSpecs.cs +++ b/src/chocolatey.tests.integration/infrastructure/commands/CommandExecutorSpecs.cs @@ -20,6 +20,7 @@ namespace chocolatey.tests.integration.infrastructure.commands using chocolatey.infrastructure.app; using chocolatey.infrastructure.commands; using chocolatey.infrastructure.filesystem; + using NUnit.Framework; using Should; public class CommandExecutorSpecs @@ -35,6 +36,8 @@ public override void Context() } } + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_CommandExecutor_errors : CommandExecutorSpecsBase { private int result; @@ -77,6 +80,8 @@ public void should_message_the_error() } } + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_CommandExecutor_is_given_a_nonexisting_process : CommandExecutorSpecsBase { private string result; From d7ca566fbcd925429273a33826c5d763ce62559c Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 17:01:30 -0500 Subject: [PATCH 04/10] (#2434) DotNetFileSystemSpecs fix/exclude broken tests on Mono This fixes a typo that affects non-windows platforms in one test and excludes two broken tests. --- .../infrastructure/filesystem/DotNetFileSystemSpecs.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/chocolatey.tests.integration/infrastructure/filesystem/DotNetFileSystemSpecs.cs b/src/chocolatey.tests.integration/infrastructure/filesystem/DotNetFileSystemSpecs.cs index 4e39b985e9..3894e7d56b 100644 --- a/src/chocolatey.tests.integration/infrastructure/filesystem/DotNetFileSystemSpecs.cs +++ b/src/chocolatey.tests.integration/infrastructure/filesystem/DotNetFileSystemSpecs.cs @@ -74,7 +74,7 @@ public void GetExecutablePath_should_find_existing_executable_with_extension() FileSystem.get_executable_path("cmd.exe").ShouldEqual( Platform.get_platform() == PlatformType.Windows ? "c:\\windows\\system32\\cmd.exe" - : "cmd", + : "cmd.exe", StringComparer.OrdinalIgnoreCase ); } @@ -139,6 +139,8 @@ public void GetFiles_should_return_files_that_meet_the_pattern() } [Fact] + [WindowsOnly] + [Platform(Exclude = "Mono")] public void GetFiles_should_return_files_that_meet_the_pattern_regardless_of_case() { string filePath = FileSystem.combine_paths(ContextPath, "chocolateyInstall.ps1"); @@ -189,6 +191,8 @@ public void GetDirectories_should_return_a_string_array_with_directories() } [Category("Integration")] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_setting_file_attributes_with_dotNetFileSystem : DotNetFileSystemSpecsBase { public override void Context() From 57eae32d7badc6f78924d29bf8743b40c9175f93 Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 17:04:03 -0500 Subject: [PATCH 05/10] (#2434) ListScenarios exclude broken test on Mono --- src/chocolatey.tests.integration/scenarios/ListScenarios.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/chocolatey.tests.integration/scenarios/ListScenarios.cs b/src/chocolatey.tests.integration/scenarios/ListScenarios.cs index 71416d9fed..f3a42c5617 100644 --- a/src/chocolatey.tests.integration/scenarios/ListScenarios.cs +++ b/src/chocolatey.tests.integration/scenarios/ListScenarios.cs @@ -25,6 +25,7 @@ namespace chocolatey.tests.integration.scenarios using chocolatey.infrastructure.app.services; using chocolatey.infrastructure.results; using NuGet; + using NUnit.Framework; using Should; public class ListScenarios @@ -58,6 +59,8 @@ public override void Because() } [Fact] + [WindowsOnly] + [Platform(Exclude = "Mono")] public void should_list_available_packages_only_once() { MockLogger.contains_message_count("upgradepackage").ShouldEqual(1); From 44e71e2dd2c796d3a8edd37f97cf050cd761a162 Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 17:13:39 -0500 Subject: [PATCH 06/10] (#2434) Use correct directory separator in test scenarios Fixes the directory separator for non-Windows systems in the InstallScenarios, UpgradeScenarios, and UninstallScenarios. --- .../scenarios/InstallScenarios.cs | 4 ++-- .../scenarios/UninstallScenarios.cs | 2 +- .../scenarios/UpgradeScenarios.cs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs b/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs index 1354025224..7a104c9ea8 100644 --- a/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs +++ b/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs @@ -327,7 +327,7 @@ public class when_installing_packages_with_packages_config : ScenariosBase public override void Context() { base.Context(); - var packagesConfig = "{0}\\context\\testing.packages.config".format_with(Scenario.get_top_level()); + var packagesConfig = "{0}{1}context{1}testing.packages.config".format_with(Scenario.get_top_level(), Path.DirectorySeparatorChar); Configuration.PackageNames = Configuration.Input = packagesConfig; Scenario.add_packages_to_source_location(Configuration, "hasdependency.1.0.0*" + Constants.PackageExtension); Scenario.add_packages_to_source_location(Configuration, "isdependency.1.0.0*" + Constants.PackageExtension); @@ -3114,7 +3114,7 @@ public class when_installing_a_package_from_a_nupkg_file : ScenariosBase public override void Context() { base.Context(); - Configuration.PackageNames = Configuration.Input = "{0}\\installpackage.1.0.0.nupkg".format_with(Configuration.Sources); + Configuration.PackageNames = Configuration.Input = "{0}{1}installpackage.1.0.0.nupkg".format_with(Configuration.Sources, Path.DirectorySeparatorChar); } public override void Because() diff --git a/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs b/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs index 19d3e8c1c1..72bc798cb7 100644 --- a/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs +++ b/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs @@ -326,7 +326,7 @@ public class when_uninstalling_packages_with_packages_config : ScenariosBase public override void Context() { base.Context(); - var packagesConfig = "{0}\\context\\testing.packages.config".format_with(Scenario.get_top_level()); + var packagesConfig = "{0}{1}context{1}testing.packages.config".format_with(Scenario.get_top_level(), Path.DirectorySeparatorChar); Configuration.PackageNames = Configuration.Input = packagesConfig; } diff --git a/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs b/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs index 364f69ac9f..c40902f79e 100644 --- a/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs +++ b/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs @@ -1202,7 +1202,7 @@ public class when_upgrading_packages_with_packages_config : ScenariosBase public override void Context() { base.Context(); - var packagesConfig = "{0}\\context\\testing.packages.config".format_with(Scenario.get_top_level()); + var packagesConfig = "{0}{1}context{1}testing.packages.config".format_with(Scenario.get_top_level(), Path.DirectorySeparatorChar); Configuration.PackageNames = Configuration.Input = packagesConfig; } From 4a5d1374473286091135bac61991d36380b05043 Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 17:19:13 -0500 Subject: [PATCH 07/10] (#2434) UpgradeScenarios exclude broken tests on Mono --- .../scenarios/UpgradeScenarios.cs | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs b/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs index c40902f79e..e70fdf071a 100644 --- a/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs +++ b/src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs @@ -202,6 +202,8 @@ public void should_contain_a_message_that_no_packages_can_be_upgraded() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_an_existing_package_happy_path : ScenariosBase { private PackageResult _packageResult; @@ -339,6 +341,8 @@ public void should_have_executed_chocolateyInstall_script_for_new_package() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_an_existing_package_with_prerelease_available_without_prerelease_specified : ScenariosBase { private PackageResult _packageResult; @@ -429,6 +433,8 @@ public void should_match_the_original_package_version() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_an_existing_package_with_prerelease_available_and_prerelease_specified : ScenariosBase { private PackageResult _packageResult; @@ -573,6 +579,8 @@ public void should_have_executed_chocolateyInstall_script_for_new_package() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_an_existing_prerelease_package_without_prerelease_specified : ScenariosBase { private PackageResult _packageResult; @@ -906,6 +914,8 @@ public void should_only_find_the_last_stable_version() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_force_upgrading_a_package : ScenariosBase { private PackageResult _packageResult; @@ -1106,6 +1116,8 @@ public void should_match_the_existing_version_of_one_dot_zero_dot_zero() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_force_upgrading_a_package_that_does_not_have_available_upgrades : ScenariosBase { private PackageResult _packageResult; @@ -1219,6 +1231,8 @@ public void should_throw_an_error_that_it_is_not_allowed() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_with_readonly_files : ScenariosBase { private PackageResult _packageResult; @@ -1319,6 +1333,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_with_a_read_and_delete_share_locked_file : ScenariosBase { private PackageResult _packageResult; @@ -1426,6 +1442,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_with_an_exclusively_locked_file : ScenariosBase { private PackageResult _packageResult; @@ -1527,6 +1545,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_with_added_files : ScenariosBase { private PackageResult _packageResult; @@ -1606,6 +1626,8 @@ public void should_match_the_upgrade_version_of_one_dot_one_dot_zero() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_with_changed_files : ScenariosBase { private PackageResult _packageResult; @@ -1783,6 +1805,8 @@ public void should_have_expected_error_in_package_result() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_that_is_not_installed : ScenariosBase { private PackageResult _packageResult; @@ -1854,6 +1878,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_that_is_not_installed_and_failing_on_not_installed : ScenariosBase { private PackageResult _packageResult; @@ -1942,6 +1968,8 @@ public void should_have_expected_error_in_package_result() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_that_errors : ScenariosBase { private PackageResult packageResult; @@ -2790,6 +2818,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_with_config_transforms : ScenariosBase { private PackageResult _packageResult; @@ -2886,6 +2916,8 @@ public void should_add_the_insertNew_value_in_the_config_due_to_XDT_InsertIfMiss } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_a_package_with_config_transforms_when_config_was_edited : ScenariosBase { private PackageResult _packageResult; @@ -3055,6 +3087,8 @@ public void should_skip_packages_without_upgrades() } [Concern(typeof(ChocolateyUpgradeCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_upgrading_all_packages_with_prereleases_installed : ScenariosBase { public override void Context() From f6050e2794cf155c599af4666e3f08688a1c32c4 Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 17:22:22 -0500 Subject: [PATCH 08/10] (#2434) InstallScenarios exclude broken tests on Mono --- .../scenarios/InstallScenarios.cs | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs b/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs index 7a104c9ea8..326e0db85b 100644 --- a/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs +++ b/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs @@ -28,6 +28,7 @@ namespace chocolatey.tests.integration.scenarios using chocolatey.infrastructure.commands; using chocolatey.infrastructure.results; using NuGet; + using NUnit.Framework; using Should; using IFileSystem = chocolatey.infrastructure.filesystem.IFileSystem; @@ -55,6 +56,8 @@ public override void Context() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_noop_installing_a_package : ScenariosBase { public override void Context() @@ -150,6 +153,8 @@ public void should_contain_a_message_that_it_was_unable_to_find_package() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_installing_a_package_happy_path : ScenariosBase { private PackageResult packageResult; @@ -539,6 +544,8 @@ public void should_ave_warning_package_result() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_force_installing_an_already_installed_package : ScenariosBase { private PackageResult packageResult; @@ -641,6 +648,8 @@ public void should_have_a_version_of_one_dot_zero_dot_zero() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_force_installing_an_already_installed_package_that_errors : ScenariosBase { private PackageResult packageResult; @@ -720,6 +729,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_force_installing_an_already_installed_package_with_a_read_and_delete_share_locked_file : ScenariosBase { private PackageResult packageResult; @@ -820,6 +831,8 @@ public void should_have_a_version_of_one_dot_zero_dot_zero() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_force_installing_an_already_installed_package_with_with_an_exclusively_locked_file : ScenariosBase { private PackageResult packageResult; @@ -1083,6 +1096,8 @@ public void should_have_expected_error_in_package_result() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_installing_a_package_that_errors : ScenariosBase { private PackageResult packageResult; @@ -1262,6 +1277,8 @@ public void should_have_a_version_of_one_dot_zero() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_installing_a_package_that_has_nonterminating_errors_with_fail_on_stderr : ScenariosBase { private PackageResult packageResult; @@ -3107,6 +3124,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_installing_a_package_from_a_nupkg_file : ScenariosBase { private PackageResult packageResult; @@ -3279,6 +3298,8 @@ public void should_have_a_version_of_one_dot_zero_dot_zero() } [Concern(typeof(ChocolateyInstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_installing_a_package_with_config_transforms : ScenariosBase { private PackageResult packageResult; From 456938145bf01ffed5d6783f430bf294db7e5860 Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Sat, 30 Oct 2021 17:24:16 -0500 Subject: [PATCH 09/10] (#2434) UninstallScenarios exclude broken tests on Mono --- .../scenarios/UninstallScenarios.cs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs b/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs index 72bc798cb7..854b33e86a 100644 --- a/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs +++ b/src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs @@ -60,6 +60,8 @@ public override void Context() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_noop_uninstalling_a_package : ScenariosBase { public override void Context() @@ -135,6 +137,8 @@ public void should_contain_a_message_that_it_was_unable_to_find_package() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_uninstalling_a_package_happy_path : ScenariosBase { private PackageResult packageResult; @@ -343,6 +347,8 @@ public void should_throw_an_error_that_it_is_not_allowed() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_uninstalling_a_package_with_readonly_files : ScenariosBase { private PackageResult _packageResult; @@ -409,6 +415,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_uninstalling_a_package_with_a_read_and_delete_share_locked_file : ScenariosBase { private PackageResult _packageResult; @@ -563,6 +571,8 @@ public void should_not_have_warning_package_result() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_uninstalling_a_package_with_added_files : ScenariosBase { private PackageResult packageResult; @@ -661,6 +671,8 @@ public void config_should_match_package_result_name() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_uninstalling_a_package_with_changed_files : ScenariosBase { private PackageResult packageResult; @@ -759,6 +771,8 @@ public void config_should_match_package_result_name() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_force_uninstalling_a_package_with_added_and_changed_files : ScenariosBase { private PackageResult packageResult; @@ -940,6 +954,8 @@ public void should_have_an_error_package_result() } [Concern(typeof(ChocolateyUninstallCommand))] + [WindowsOnly] + [Platform(Exclude = "Mono")] public class when_uninstalling_a_package_that_errors : ScenariosBase { private PackageResult packageResult; From 740252f79b561cb02171248a69abe08d23ac58b5 Mon Sep 17 00:00:00 2001 From: TheCakeIsNaOH Date: Fri, 5 Nov 2021 18:48:41 -0500 Subject: [PATCH 10/10] (#2434) Test workflow run integration tests on Ubuntu and MacOS --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index eb50f35a9b..34c76b61be 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,7 +19,7 @@ jobs: chmod +x build.sh $GITHUB_WORKSPACE//build.sh -v - name: Test with Nunit on Mono - run: $GITHUB_WORKSPACE//test.sh + run: $GITHUB_WORKSPACE//test.sh integration - name: Upload Ubuntu build results uses: actions/upload-artifact@v2 # Always upload build results @@ -67,7 +67,7 @@ jobs: chmod +x build.sh $GITHUB_WORKSPACE//build.sh -v - name: Test with Nunit on Mono - run: $GITHUB_WORKSPACE//test.sh + run: $GITHUB_WORKSPACE//test.sh integration - name: Upload MacOS build results uses: actions/upload-artifact@v2 # Always upload build results