Review format of lyrics in .mid

[TheBoxyBear]

According to the .mid format reference, text data for vocals is stored as events that may be shared across tracks. If so, the model should be adjusted accordingly to not allow different lyrics for each track.

[TheNathannator]

The lyric text events themselves are not shared across tracks, only the lyric phrase markers are. Each harmony part has its own set of lyrics, including HARM3.

[TheBoxyBear]

So global: Start and end of each phrase

Per standard/harmony track: Positions, pitches and text.

@TheNathannator Know of any midi chart with harmonies for reference?

[TheNathannator]

A good amount of the Rock Band 3 setlist has them, along with various RB3 customs.

That list of associations sounds correct off the top of my head, don't think there's anything else to note for that.

[TheBoxyBear]

There's also the sharing of SP across harmonies and that seems to be a cascade of phrases, 1 defining for 1/2, 2 for 3 and 3 having no phrases.

Considering cutting vocals altogether for the initial release while a new model is imagined, but such a model also seems difficult to design. It would either be complex to force correct states, or have a lots of runtime error cases when writing. Either way, it would almost definitely not fit in the mold of Instrument classes but this isn't a huge issue as vocals can always be treated as a distinct component.

[TheBoxyBear]

Found song with hamonies: Amy Winehouse - Rehab

[TheBoxyBear]

---
title: Vocals
---
classDiagram

    class PhraseMarker {
        uint Start
        uint End
    }

    class VocalsNote{
        uint Position
        uint Length
        VocalsPitch Pitch
        string Text
    }

    class VocalsTrack {
        List[PhraseMarker] Phrases
    }

    VocalsTrack <|-- StandardVocalsTrack

    class StandardVocalsTrack {
        List[VocalsNote] Notes
    }

    VocalsTrack <|-- HarmonicsVocalsTrack

    class HarmonicsVocalsTrack {
        List[VocalsNote] Harmonics1
        List[VocalsNote] Harmonics2
        List[VocalsNote] Harmonics3
    }

    class Vocals {
        StandardVocalsTrack Standard;
        HarmonicsVocalsTrack Harmonics;
    }

Loading

[TheBoxyBear]

Lists of notes should be replaced with a class as afaik from the docs, each one can have local events. However, a name would need to be found other than Track to differentiate the two levels.