Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grt::have_routes return 0/1 silently #6293

Closed
oharboe opened this issue Dec 4, 2024 · 2 comments · Fixed by #6305
Closed

Make grt::have_routes return 0/1 silently #6293

oharboe opened this issue Dec 4, 2024 · 2 comments · Fixed by #6305
Assignees
Labels
grt Global Routing

Comments

@oharboe
Copy link
Collaborator

oharboe commented Dec 4, 2024

Description

When scripting, it is useful to check if an operation that needs global routing should be skipped or not using grt::have_routes.

However, grt::have_routes prints warnings and errors.

[WARNING GRT-0097] No global routing found for nets. 0

Or if run with make gui_floorplan

>>> grt::have_routes
[ERROR GRT-0010] Instance ctrl.state.out\[0\]$_DFF_P_ is not placed.
[ERROR GUI-0070] GRT-0010

Since these errors/warnings are logged, catch is no help:

>>> catch {grt::have_routes} error
[ERROR GRT-0010] Instance ctrl.state.out\[0\]$_DFF_P_ is not placed.
1

Suggested Solution

grt::have_routes should silently return 0/1, but it can returns warnings and errors.

Additional Context

No response

@maliberty
Copy link
Member

grt::have_routes should silently return 0/1, but it can returns warnings and errors.

I don't see how it can be silent, returning 0/1, and also return errors/warnings. I think we can just drop the error.

oharboe added a commit to Pinata-Consulting/OpenROAD that referenced this issue Dec 5, 2024
grt::have_routes should be silent in .tcl, AntennaChecker.cc has another
warning of its own and EstimateireParasitics.cc uses placement if
global routing is not available and it doesn't look like it should output
a warning

fixes The-OpenROAD-Project#6293

Signed-off-by: Øyvind Harboe <[email protected]>
@oharboe
Copy link
Collaborator Author

oharboe commented Dec 5, 2024

@maliberty @luis201420 I made a fleeting vain attempt at removing the warning #6305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grt Global Routing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants