started implementation of vars.py #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhruvacube
added
bug
Dhruvacube
requested changes
Oct 4, 2021
There was a problem hiding this comment.
Hey @eitozx thanks for this amazing contribution. I see you have taken time to contribute to my broken v2.0 of Minato Namikaze, I appreciated these contribution.
But see I have made some review comments please check those and change it accordingly :)
|
gotcha. |
|
@eitozx just ping me when done |
|
@Dhruvacube done |
Dhruvacube
approved these changes
Oct 5, 2021
|
@all-contributors please add @eitozx for Infrastructure |
|
I've put up a pull request to add @eitozx! 🎉 |
Dhruvacube
added a commit
that referenced
this pull request
Jun 23, 2022
started implementation of vars.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
.env.exampleto make it easy for contributors to understand .env structure (formality lol).vars.py.requirements.txtwith some modules that were not listed.Note: Implementation of
vars.pyisn't completed yet (and i'm not sure either)