From b5c836587cac41d6b922c7c2bfac5dcd9201884a Mon Sep 17 00:00:00 2001
From: pstowasser01 <60797434+pstowasser01@users.noreply.github.com>
Date: Fri, 11 Oct 2024 18:07:49 +0200
Subject: [PATCH] feat(front): Add Threashold to onMouseMove to supress small
 movements (#467)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In order to enable drag the movement has to be bigger than a customizable threshold so small movements will still trigger the select highlight!

Co-authored-by: Antonio González Viegas <antoniogviegas@hotmail.com>
---
 .../front/src/fragments/Highlighter/index.ts  | 49 +++++++++++++------
 1 file changed, 33 insertions(+), 16 deletions(-)

diff --git a/packages/front/src/fragments/Highlighter/index.ts b/packages/front/src/fragments/Highlighter/index.ts
index d55691925..47450a0a3 100644
--- a/packages/front/src/fragments/Highlighter/index.ts
+++ b/packages/front/src/fragments/Highlighter/index.ts
@@ -107,6 +107,12 @@ export class Highlighter extends OBC.Component implements OBC.Disposable {
   /** Styles with auto toggle will be unselected when selected twice. */
   autoToggle = new Set<string>();
 
+  /** Position of the mouse on mouseDown. */
+  private mouseDownPosition = {x: 0, y: 0};
+
+  /** Threshhold on how much the mouse have to move until its considered movement */
+  mouseMoveThreshold = 5
+
   /** If defined, only the specified elements will be selected by the specified style. */
   selectable: { [name: string]: FragmentIdMap } = {};
 
@@ -629,9 +635,11 @@ export class Highlighter extends OBC.Component implements OBC.Disposable {
     this.selection[this.config.hoverName] = {};
   };
 
-  private onMouseDown = () => {
+  private onMouseDown = (e: MouseEvent) => {
     if (!this.enabled) return;
+    this.mouseDownPosition = {x: e.clientX, y: e.clientY}
     this._mouseState.down = true;
+
   };
 
   private onMouseUp = async (event: MouseEvent) => {
@@ -656,29 +664,38 @@ export class Highlighter extends OBC.Component implements OBC.Disposable {
     }
   };
 
-  private onMouseMove = async () => {
+  private onMouseMove = async (e: MouseEvent) => {
     if (!this.enabled) return;
+
+    // Calculate the distance the mouse has moved since mouse down
+    const dx = e.clientX - this.mouseDownPosition.x;
+    const dy = e.clientY - this.mouseDownPosition.y;
+    const moveDistance = Math.sqrt(dx * dx + dy * dy);
+
     const { hoverName, hoverEnabled } = this.config;
     if (this._mouseState.moved) {
       this.clear(hoverName);
       return;
     }
-
-    this._mouseState.moved = this._mouseState.down;
-    const excluded: FRAGS.FragmentIdMap = {};
-    for (const name in this.selection) {
-      if (name === hoverName) continue;
-      const fragmentIdMap = this.selection[name];
-      for (const fragmentID in fragmentIdMap) {
-        if (!(fragmentID in excluded)) excluded[fragmentID] = new Set();
-        const expressIDs = fragmentIdMap[fragmentID];
-        for (const expressID of expressIDs) {
-          excluded[fragmentID].add(expressID);
+    
+    // If the distance is greater than the threshold, set dragging to true
+    if (moveDistance > this.mouseMoveThreshold) {
+      this._mouseState.moved = this._mouseState.down;
+      const excluded: FRAGS.FragmentIdMap = {};
+      for (const name in this.selection) {
+        if (name === hoverName) continue;
+        const fragmentIdMap = this.selection[name];
+        for (const fragmentID in fragmentIdMap) {
+          if (!(fragmentID in excluded)) excluded[fragmentID] = new Set();
+          const expressIDs = fragmentIdMap[fragmentID];
+          for (const expressID of expressIDs) {
+            excluded[fragmentID].add(expressID);
+          }
         }
       }
-    }
-    if (hoverEnabled) {
-      await this.highlight(this.config.hoverName, true, false, excluded);
+      if (hoverEnabled) {
+        await this.highlight(this.config.hoverName, true, false, excluded);
+      }
     }
   };
 }