Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic_claim missing as_object #101

Closed
AndrewLipscomb opened this issue Sep 18, 2020 · 2 comments
Closed

basic_claim missing as_object #101

AndrewLipscomb opened this issue Sep 18, 2020 · 2 comments
Labels

Comments

@AndrewLipscomb
Copy link

Just reading through the header for basic_claim and can see there is no as_object() to match the as_string(), as_array() and other similar functions

Not good with the standard by any means - but from the spec

For JWTs, while claim names are strings, claim values can be any JSON type

Of which an object should be fine. Is there a reason for as_object to be omitted or is this an oversight?

I can make a pull if its an oversight

@prince-chrismc
Copy link
Collaborator

oversight would be possible. I think it simply was not required to handle the JWTs structure, signing or verification.

I am certainly in favor of this. Please open a PR.

It's possible to use to_json() as an alternative.

@prince-chrismc
Copy link
Collaborator

Closing as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants