🚧 Dev ➾ Handle installation of non-existent plugin

[mweichert]

🔗 Epic|Feature Link

No response

🚥 Definition of Done

• 🎯 Planning and Design
• 🏎️ Dev Implementation Complete
• ♾️ PR Merged
• 🏆 Product Acceptance

🧰 Work Description

When npm install fails as part of taq install, we don't capture or process the failure and just assume that the plugin was installed successfully.

For instance, if you run taq install thecatcameback we will assume that npm install completed successfully, and then try to read the package.json of the plugin to get its valid package name which fails and produces this error:

Could not read /Users/mweichert/Projects/test-project/node_modules/thecatcameback/package.json

The taq install thecatcameback task will return exit code 9, as this line will be triggered in our error response logic:

.with({ kind: 'E_READFILE' }, err => [9, err.msg])

✅ To Do

We should check the status code of the npm install command and if non-zero, throw a new TaqError of kind 'E_INSTALL_PLUGINand then handle that in ourdisplayError` function in cli.ts.

We can then unskip this test in taqueria-cli-e2e-smoke-spec.ts:

test.skip('install a package that does not exist will  error', async () => {
		const { execute, cleanup, spawn } = await prepareEnvironment();
		const { waitForText } = await spawn('taq', 'init test-project --debug');
		await waitForText("Project taq'ified!");
		const { code } = await execute('taq', 'install acoupleofecadhamburgers -p foobar');
		expect(code).toBe(1);
		await cleanup();
	});

⚖️ Acceptance Criteria

✨ Functional:

• Running taq install thecatcameback should return a exit code and display an appropriate error message
• The install a package that does not exist will error test is unskipped and working

🔭 Scope

No response

Code of Conduct

• I agree to follow this project's Code of Conduct