diff --git a/Source/Layout/ASDimension.mm b/Source/Layout/ASDimension.mm index 603885e44..5e42255ab 100644 --- a/Source/Layout/ASDimension.mm +++ b/Source/Layout/ASDimension.mm @@ -47,7 +47,6 @@ ASOVERLOADABLE ASDimension ASDimensionMake(NSString *dimension) } } - ASDisplayNodeCAssert(NO, @"Parsing dimension failed for: %@", dimension); return ASDimensionAuto; } diff --git a/Tests/ASDimensionTests.mm b/Tests/ASDimensionTests.mm index fab3aaf97..6832dc5e8 100644 --- a/Tests/ASDimensionTests.mm +++ b/Tests/ASDimensionTests.mm @@ -29,7 +29,7 @@ - (void)testCreatingDimensionUnitAutos { XCTAssertNoThrow(ASDimensionMake(ASDimensionUnitAuto, 0)); XCTAssertThrows(ASDimensionMake(ASDimensionUnitAuto, 100)); - XCTAssertThrows(ASDimensionMake(@"")); + ASXCTAssertEqualDimensions(ASDimensionAuto, ASDimensionMake(@"")); ASXCTAssertEqualDimensions(ASDimensionAuto, ASDimensionMake(@"auto")); }