-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash on iOS 10 occasionly #960
Comments
Try to use setContentOffset in MainThread DispatchQueue |
I have same issue with Just open view with Thread Queue:
and `bt all` :
|
@zoka2305 @AlasKuNull Would you be up for pulling together a small project with the issue happening? |
I am also experiencing this issue, but I never was able to reproduce it locally, crash log is identical -
|
@Shaninnik Could you pull a small project together to aid in debugging? |
@ay8s I would be glad to help, but unfortunately I do not see how. I don't even know at what specific part of the app it is crashing, I have never seen this crash personally, and crash log is not informative enough. But according to crashlytics this happens quite a lot, on both iOS 9 and iOS 10. And started happening after we released an update that fixed a number of memory leaks. We also have another variation of this crash:
override init() {
loader = ASDisplayNode { () -> UIView in
let view = UIActivityIndicatorView(activityIndicatorStyle: .gray)
view.startAnimating()
return view
}
super.init()
baseInit()
} |
I've got exactly the same crash on iOS 9/10. I think it started after I've added ASEditableTextNode to the cell in ASTableNode. Any fix or workaround? |
Same crash for iOS 10, with ASEditableTextNode in cell node in ASTableNode. If the table node's content height is large enough (maybe more than 5000 points), crash happened after pop the view controller. |
I don't know exactly the problem of It can be a problem with ASEditableTextNode deallocate. |
This problem is getting more and more worse in our recently releases in iOS9 and iOS10. So I fork a version of 2.6(because of supporting iOS8), and revert the code of ASEditableTextNode and ASTextKitComponents to 2.5, and resolved this bug. |
@huangxinyu1213 Hey, what code of ASEditableTextNode / ASTextKitComponents did you have to revert to resolve the bug? |
Can confirm that this is top 1 crash for our app. One of the deallocated view controllers has a lot of ASEditableTextNodes inside scroll view that is inside ASPagerNode |
@maicki I just replace all ASEditableTextNode and ASTextKitComponents code with v2.5, and everything is OK. |
Crash on #0 Thread
I added the code in ASTextKitComponentsTextView file, but is also crash occasionly in iOS 10.
`- (void)setContentOffset:(CGPoint)contentOffset {
}
(void)dealloc {
_isDeallocing = YES;
}`
The text was updated successfully, but these errors were encountered: