Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture doesn't support custom UICollectionViewLayout. #1959

Open
ekazaev opened this issue Jan 29, 2021 · 1 comment
Open

Texture doesn't support custom UICollectionViewLayout. #1959

ekazaev opened this issue Jan 29, 2021 · 1 comment

Comments

@ekazaev
Copy link

ekazaev commented Jan 29, 2021

Texture doesnt support custom UICollectionViewLayout as it is hardcoded to support only UICollectionViewFlowLayout.

ASCollectionViewProxy intercepts the selector collectionView:layout:sizeForItemAtIndexPath: and propagates the values directly to the UICollectionViewFlowLayout in the prepare method. If any other layout has a different method signature or a different ways of setting the item sizes, ASCollectionView stops to work.
https://developer.apple.com/documentation/uikit/uicollectionviewdelegateflowlayout/1617708-collectionview

The second issue is that _ASCollectionViewCell does not implement preferredLayoutAttributesFitting so it does not propagate the desired size in a way that is natural for the UICollectionViewLayout after it was calculated. That must be fixed to support any other custom UICollectionViewLayout.

Please see the example project. Just uncomment one or another solution in TextureController.swift
TestTexture.zip

@jeffersonsetiawan
Copy link

Didn't know much about this, maybe you can take a look at ASCollectionViewLayoutInspecting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants