Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 12 build error when imported AuthenticationServices #1871

Closed
hovox opened this issue Jun 25, 2020 · 7 comments
Closed

Xcode 12 build error when imported AuthenticationServices #1871

hovox opened this issue Jun 25, 2020 · 7 comments
Assignees

Comments

@hovox
Copy link

hovox commented Jun 25, 2020

When building with Xcode 12 beta1 we are getting this error Redefinition of 'ASViewController' as different kind of symbol
Seems cause is this in ASFoundation.h:

#if __has_include(<UIKit/UIViewController.h>)
typedef UIViewController ASViewController;
#endif

I suppose we need to rename ASViewController to something else ? E.g. AS => TK as a texture kit ?

@ay8s
Copy link
Collaborator

ay8s commented Jun 25, 2020

Wonder if you have any preference on this one @garrettmoon? Wonder if it might be a good thing to slot into 3.0.

@hovox
Copy link
Author

hovox commented Jun 26, 2020

I have renamed ASViewController into ASDKViewController and AS_EXTERN into ASDK_EXTERN and seems that is enough.

Not related to this issue but related to Xcode 12, there are some new warnings:

'_Atomic' is a C11 extension

@garrettmoon
Copy link
Member

Of course this would happen after we put out an RC.

@garrettmoon
Copy link
Member

@hovox can you confirm that this is fixed on master? I want to get it into the 3.0 release.

@ay8s
Copy link
Collaborator

ay8s commented Jun 30, 2020

Working for us @garrettmoon 👍

@garrettmoon
Copy link
Member

Gonna close this out, please lemme know if I should reopen!

@mycroftcanner
Copy link

mycroftcanner commented Jul 6, 2021

There is a new conflict with ASAuthenticationServices #2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants