From 999cb6e485dfa92f25a2dfe698dff968c620d18c Mon Sep 17 00:00:00 2001 From: Garrett Moon Date: Thu, 21 Feb 2019 15:21:19 -0800 Subject: [PATCH] Don't return non-animated GIFs for animation (update to latest PINRemoteImage beta) (#940) * Don't return non-animated GIFs for animation * Update to latest PINRemoteImage beta --- Cartfile | 4 ++-- Podfile | 2 +- Source/Details/ASPINRemoteImageDownloader.mm | 2 +- Texture.podspec | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Cartfile b/Cartfile index f1a449b01..ea145be2c 100644 --- a/Cartfile +++ b/Cartfile @@ -1,2 +1,2 @@ -github "pinterest/PINRemoteImage" "3.0.0-beta.13" -github "pinterest/PINCache" "3.0.1-beta.6" +github "pinterest/PINRemoteImage" "3.0.0-beta.14" +github "pinterest/PINCache" "3.0.1-beta.7" diff --git a/Podfile b/Podfile index dfb2350e8..98479737e 100644 --- a/Podfile +++ b/Podfile @@ -8,7 +8,7 @@ target :'AsyncDisplayKitTests' do pod 'JGMethodSwizzler', :git => 'https://github.com/JonasGessner/JGMethodSwizzler', :branch => 'master' # Only for buck build - pod 'PINRemoteImage', '3.0.0-beta.13' + pod 'PINRemoteImage', '3.0.0-beta.14' end #TODO CocoaPods plugin instead? diff --git a/Source/Details/ASPINRemoteImageDownloader.mm b/Source/Details/ASPINRemoteImageDownloader.mm index 35b1c919b..0276946f9 100644 --- a/Source/Details/ASPINRemoteImageDownloader.mm +++ b/Source/Details/ASPINRemoteImageDownloader.mm @@ -332,7 +332,7 @@ - (void)setPriority:(ASImageDownloaderPriority)priority withDownloadIdentifier:( - (id)alternateRepresentationWithData:(NSData *)data options:(PINRemoteImageManagerDownloadOptions)options { #if PIN_ANIMATED_AVAILABLE - if ([data pin_isGIF]) { + if ([data pin_isAnimatedGIF]) { return data; } #if PIN_WEBP_AVAILABLE diff --git a/Texture.podspec b/Texture.podspec index dbf43e04d..ef915ac59 100644 --- a/Texture.podspec +++ b/Texture.podspec @@ -39,7 +39,7 @@ Pod::Spec.new do |spec| end spec.subspec 'PINRemoteImage' do |pin| - pin.dependency 'PINRemoteImage/iOS', '= 3.0.0-beta.13' + pin.dependency 'PINRemoteImage/iOS', '= 3.0.0-beta.14' pin.dependency 'PINRemoteImage/PINCache' pin.dependency 'Texture/Core' end