Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+C no longer alerts quit help (unreleased) #5466

Closed
TomJGooding opened this issue Jan 9, 2025 · 4 comments
Closed

Ctrl+C no longer alerts quit help (unreleased) #5466

TomJGooding opened this issue Jan 9, 2025 · 4 comments

Comments

@TomJGooding
Copy link
Contributor

Following the (yet unreleased) updates with text selection, reflexively hitting Ctrl+C no longer alerts the user that this doesn't quit the app.

Was this intentional, or should this alert still be sent when no text is selected?
@willmcgugan
Copy link
Collaborator

No intentional per se, more of a side effect of the ctrl+c being bound to copy text.

I think yes, it probably would be worthwhile still sending the notification of no text is selected.

@Textualize Textualize deleted a comment from github-actions bot Jan 9, 2025
@TomJGooding
Copy link
Contributor Author

Closed by 4ce6b79 (can't believe I missed SkipAction when I had a quick look at fixing this myself!).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

@willmcgugan
Copy link
Collaborator

Closed by 4ce6b79 (can't believe I missed SkipAction when I had a quick look at fixing this myself!).

It is super-useful, although there is so rarely a need to use it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willmcgugan @TomJGooding