Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown escape sequences shouldn't cause freeze (e.g. ^[d, ^[f, ^[b) #541

Closed
darrenburns opened this issue May 25, 2022 · 2 comments · Fixed by #570
Closed

Unknown escape sequences shouldn't cause freeze (e.g. ^[d, ^[f, ^[b) #541

darrenburns opened this issue May 25, 2022 · 2 comments · Fixed by #570
Assignees

Comments

@darrenburns
Copy link
Member

These sequences get sent by iTerm when natural text editing mode is on by default.

They also get sent by default by Terminal.app, so pressing Option + Left, Option + Right, Option + Delete in that also results in a crash.

They're and to move the cursor back and forward by full words, and delete the next word forward.

Right now, when Textual receives them, the app becomes completely unresponsive.

Perhaps we need some kind of timeout inside the driver which reads input? Right now I'm having to kill -9 relatively often because of it.

The natural text editing mode is relatively popular in iTerm (

@willmcgugan
Copy link
Collaborator

At the moment we have no way to recover there is a timeout, which could lead to missing keys or garbage keys.

We should parse the keys more intelligently though. So we can recover from an unknown key.

@darrenburns darrenburns self-assigned this Jun 8, 2022
@darrenburns darrenburns linked a pull request Jun 16, 2022 that will close this issue
@github-actions
Copy link

Did we solve your problem?

Consider buying the Textualize developers a coffee to say thanks.

Textualize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants