Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.dark mode breaking change #5341

Closed
JoeZiminski opened this issue Dec 4, 2024 · 3 comments
Closed

.dark mode breaking change #5341

JoeZiminski opened this issue Dec 4, 2024 · 3 comments

Comments

@JoeZiminski
Copy link

JoeZiminski commented Dec 4, 2024

Just a small suggestion, I recently saw that dark mode has been superceeded by themes (which look great BTW). I had some tests that did not pick up the breaking change as the .dark attribute is still held on app vestigially (as far as I can tell). It might be worth either a) setting .dark so it still changes to textual-dark/'light' theme under the hood, or raise deprecation error if it is accessed so this gets flagged in tests.

Copy link

github-actions bot commented Dec 4, 2024

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@darrenburns
Copy link
Member

Thanks Joe! We considered this but opted to just get rid of it completely, as the migration is very simple.

We're still at v0 and about to bump to v1, where we'll be stricter about versioning this type of change.

@darrenburns darrenburns closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants