You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just a small suggestion, I recently saw that dark mode has been superceeded by themes (which look great BTW). I had some tests that did not pick up the breaking change as the .dark attribute is still held on app vestigially (as far as I can tell). It might be worth either a) setting .dark so it still changes to textual-dark/'light' theme under the hood, or raise deprecation error if it is accessed so this gets flagged in tests.
The text was updated successfully, but these errors were encountered:
Just a small suggestion, I recently saw that dark mode has been superceeded by themes (which look great BTW). I had some tests that did not pick up the breaking change as the
.dark
attribute is still held onapp
vestigially (as far as I can tell). It might be worth either a) setting.dark
so it still changes totextual-dark
/'light' theme under the hood, or raise deprecation error if it is accessed so this gets flagged in tests.The text was updated successfully, but these errors were encountered: