Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding.key_display and help panel interact poorly for comma-separated Binding definitions #5037

Closed
darrenburns opened this issue Sep 23, 2024 · 1 comment · Fixed by #5066
Closed

Binding.key_display and help panel interact poorly for comma-separated Binding definitions #5037

darrenburns opened this issue Sep 23, 2024 · 1 comment · Fixed by #5066

Comments

@darrenburns
Copy link
Member

darrenburns commented Sep 23, 2024 •
edited
Loading

If you declare a binding with commas e.g. Binding("j,down,minus", ..., key_display="foo"), the key panel will display that same "key display" for each key, resulting in repetition.

I think deduping the key displays might be enough here?

image
@TomJGooding TomJGooding mentioned this issue Sep 27, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(help panel): prevent duplicated key displays TomJGooding/textual
1 participant
@darrenburns