Assigning a message type to a class variable breaks message handlers

[arvidfm]

If you assign a message type to a class variable belonging to a class that derives from MessagePump, non-decorated message handlers stop working because the message type's handler_name incorrectly gets reassigned to use the name of the class containing the class variable as the namespace.

I ran into this when writing a general class for input prompts/modals, where I was using class variables to specify what event to treat as the "submit" event.

Simple example, where on_button_pressed won't be run unless EVENT_TYPE is removed:

from textual.app import App, ComposeResult
from textual.widgets import Button


class MyApp(App):
    # prevents on_button_pressed from running
    EVENT_TYPE = Button.Pressed

    def compose(self) -> ComposeResult:
        yield Button("Click me")

    def on_button_pressed(self) -> None:
        self.query_one(Button).label = "Clicked!"


if __name__ == '__main__':
    MyApp().run()
    # prints "on_my_app_pressed"!
    print(Button.Pressed.handler_name)

[github-actions]

We found the following entry in the FAQ which you may find helpful:

• How do I pass arguments to an app?

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.