Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate potential snapshot issue on 3.7 #3760

Closed
willmcgugan opened this issue Nov 27, 2023 · 1 comment
Closed

Investigate potential snapshot issue on 3.7 #3760

willmcgugan opened this issue Nov 27, 2023 · 1 comment
Assignees
@darrenburns

Comments

@willmcgugan
Copy link
Collaborator

I recently added _box_drawing.py which has the following line:

Quad: TypeAlias = tuple[int, int, int, int]

This is an error on Python 3.7, however it did not fail in CI which is very puzzling. Here's a CI run which I would have expected to fail: https://github.com/Textualize/textual/actions/runs/7006265082

We should investigate why this didn't fail. Otherwise we could be oblivious to such errors in the future.
@willmcgugan willmcgugan changed the title Investigate potential snapshot on 3.7 Investigate potential snapshot issue on 3.7 Nov 27, 2023
@github-actions GitHub Actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darrenburns darrenburns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willmcgugan @darrenburns