Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SystemCommand lazy #3754

Closed
willmcgugan opened this issue Nov 27, 2023 · 2 comments · Fixed by #3756
Closed

Make SystemCommand lazy #3754

willmcgugan opened this issue Nov 27, 2023 · 2 comments · Fixed by #3756
Assignees
@willmcgugan

Comments

@willmcgugan
Copy link
Collaborator

In app we import SystemCommands which import command.py.

By necessity this imports a number of widgets, which means we always load those widgets. I think we could make this lazy somehow, to improve startup time.

Couple of options:

  • Delay work until the user summons the command palette.
  • Delay work until after the first render.

Discuss with @willmcgugan once you have a plan for this.
@willmcgugan willmcgugan self-assigned this Nov 27, 2023
@willmcgugan willmcgugan mentioned this issue Nov 27, 2023
Merged
@willmcgugan
Copy link
Collaborator Author

#3756

@github-actions GitHub Actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmcgugan willmcgugan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lazy command provider Textualize/textual
1 participant
@willmcgugan