Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree - docs recommend overriding render_label to change the label, but TreeDataType appears in the signature and isn't exported, meaning if users use type hints, they'd need to import that from the private _tree module #3726

Closed
willmcgugan opened this issue Nov 22, 2023 · 1 comment · Fixed by #3730
Closed

Tree - docs recommend overriding render_label to change the label, but TreeDataType appears in the signature and isn't exported, meaning if users use type hints, they'd need to import that from the private _tree module #3726

willmcgugan opened this issue Nov 22, 2023 · 1 comment · Fixed by #3730
Assignees
@rodrigogiraoserrao

Comments

@willmcgugan
Copy link
Collaborator

willmcgugan commented Nov 22, 2023 •
edited by rodrigogiraoserrao
Loading

Add TreeDataType and other types to widgets/tree.py.

Rodrigo edit: This'll take ~30min to go over the tree/directorytree types and make sure all of them get exported correctly.
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Nov 22, 2023
@rodrigogiraoserrao rodrigogiraoserrao linked a pull request Nov 22, 2023 that will close this issue
Improve documentation. #3730
Merged
@github-actions GitHub Actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve documentation. Textualize/textual
2 participants
@willmcgugan @rodrigogiraoserrao