Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderables/background.py calls missing method #3585

Closed
patha454 opened this issue Oct 25, 2023 · 5 comments
Closed

renderables/background.py calls missing method #3585

patha454 opened this issue Oct 25, 2023 · 5 comments

Comments

@patha454
Copy link

patha454 commented Oct 25, 2023

Please give a brief but clear explanation of the issue. If you can, include a complete working example that demonstrates the bug.

A code branch in renderables/background.py calls a Rich Style method clear_meta_and_links(). The method does not appear the exist in the pinned Rich version, nor the latest Rich version.

I noticed this bug with Textual/Trogon, where the default implementations of the (F1) About and (CTRL-O) Command Info bindings trigger this bug, causing a crash.

Feel free to add screenshots and / or videos. These can be very helpful!

textual-clear-meta-links

@Textualize Textualize deleted a comment from github-actions bot Oct 25, 2023
@darrenburns
Copy link
Member

This method was added to Rich in 13.3.3.

Textual depends on rich >= 13.3.3.

https://github.com/Textualize/rich/blob/e9f75c9912ed25b9777bc0257853370951220b17/rich/style.py#L649

It looks like it might be an issue with your environment - are you using a virtualenv?

@patha454
Copy link
Author

I'm on Rich 13.3.1. That explains a lot. Seems it's just internal package management weirdness. Thanks!

@patha454
Copy link
Author

Looks like the Poetry lockfile accepts Rich >= 12.0.0

https://github.com/Textualize/textual/blob/main/poetry.lock#L856

Could it be updated? I'm not familiar with Poetry as a package manager.

@patha454 patha454 reopened this Oct 25, 2023
@darrenburns
Copy link
Member

That line is specifying the required version of Rich for one of the dependencies, pytest-textual-snapshot. It's not the version of Rich required by Textual itself.

@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants