Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make notify threadsafe #3267

Closed
willmcgugan opened this issue Sep 9, 2023 · 1 comment · Fixed by #3275
Closed

Make notify threadsafe #3267

willmcgugan opened this issue Sep 9, 2023 · 1 comment · Fixed by #3275
Assignees
@willmcgugan
Labels
enhancement New feature or request Task

Comments

@willmcgugan
Copy link
Collaborator

Consider this issue #3265

Calling anything UI related from a thread is generally not going to work. But maybe we should make it for for notify.

Suggest we add a Notification message. The notify method post this (non bubbling) message, and the handler would actually display it. That way you could call self.notify from a thread.
@davep davep added enhancement New feature or request Task labels Sep 9, 2023
@willmcgugan willmcgugan self-assigned this Sep 11, 2023
@willmcgugan willmcgugan mentioned this issue Sep 11, 2023
Merged
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmcgugan willmcgugan

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make notify thread-safe Textualize/textual
2 participants
@davep @willmcgugan