Scroll to center problem

[willmcgugan]

There's an issue with scroll_to_center that can be seen in the scroll_to_center.py snapshot.

Essentially it doesn't seem to scroll the inner-most container the first time, but does on the second time.

I did some debugging, and it appears that max_scroll_x and max_scroll_y are erroneously reporting zero, until the container becomes visible for the first time, then they have the correct values. The root cause seems to be that the virtual_size is the same as size, which is incorrect.

When fixing this, be careful not to break textual colors. If you click the last button it should scroll to the end.

This issue likely does touch on the compositor. I suspect it is something related to the _full_map structure.

[willmcgugan]

Apologies to @rodrigogiraoserrao , who's math was impeccable as always.

[rodrigogiraoserrao]

Apologies to @rodrigogiraoserrao , who's math was impeccable as always.

Give me enough time, and I'll eventually make a ridiculous math error 😆

[rodrigogiraoserrao]

For reference, likely related to #2254.

[rodrigogiraoserrao]

Give me enough time, and I'll eventually make a ridiculous math error 😆

It just happened. 🤷

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.