Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] no __version__ attribute ? #282

Closed
neutrinoceros opened this issue Sep 14, 2020 · 2 comments
Closed

[BUG] no __version__ attribute ? #282

neutrinoceros opened this issue Sep 14, 2020 · 2 comments

Comments

@neutrinoceros
Copy link
Contributor

Describe the bug

Not really a bug (but I don't think this qualifies as a feature request either):
rich has no version attribute, and the relevant info is rather stored in pyproject.toml

I have no experience with packaging with poetry. Would it make sense to you to use the python accessible version attribute in rich.__init__.py instead of pyproject.toml[tool.poetry] ? Thanks !

@willmcgugan
Copy link
Collaborator

poetry doesn't create __version__ attributes. They recommend using importlib.metadata to get the version. Details here python-poetry/poetry#144

Personally, I think its a step backwards.

@neutrinoceros
Copy link
Contributor Author

I see !
Personally I'd be happy to have a way to get the version number from outside rich, so importlib.metadata.version is a satisfactory solution to me, and I don't need it to be done internally. Thank you for your answer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants