Crash on start

[x29a]

Hi,

i upgraded my computer to Ubuntu 20.10 (from 20.04) and now lilyterm crashes on startup with the following messages:

** Message: 13:44:32.043: Can NOT connect to a existing lilyterm socket!

(lilyterm:15090): Gtk-WARNING **: 13:44:32.046: Theme parsing error: <data>:2:32: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): Gtk-WARNING **: 13:44:32.046: Theme parsing error: <data>:3:29: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): Gtk-WARNING **: 13:44:32.047: Theme parsing error: <data>:2:32: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): Gtk-WARNING **: 13:44:32.047: Theme parsing error: <data>:3:29: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): VTE-CRITICAL **: 13:44:32.047: gboolean vte_terminal_spawn_sync(VteTerminal*, VtePtyFlags, const char*, char**, char**, GSpawnFlags, GSpawnChildSetupFunc, gpointer, GPid*, GCancellable*, GError**): assertion 'envv == nullptr ||_vte_pty_check_envv(envv)' failed

(lilyterm:15090): Gtk-WARNING **: 13:44:32.048: Theme parsing error: <data>:2:32: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): Gtk-WARNING **: 13:44:32.048: Theme parsing error: <data>:3:29: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): Gtk-WARNING **: 13:44:32.048: Theme parsing error: <data>:2:32: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): Gtk-WARNING **: 13:44:32.048: Theme parsing error: <data>:3:29: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version

(lilyterm:15090): VTE-CRITICAL **: 13:44:32.048: void vte_terminal_match_set_cursor_type(VteTerminal*, int, GdkCursorType): assertion 'tag >= 0' failed

(lilyterm:15090): VTE-CRITICAL **: 13:44:32.048: void vte_terminal_match_set_cursor_type(VteTerminal*, int, GdkCursorType): assertion 'tag >= 0' failed

(lilyterm:15090): VTE-CRITICAL **: 13:44:32.049: void vte_terminal_match_set_cursor_type(VteTerminal*, int, GdkCursorType): assertion 'tag >= 0' failed

(lilyterm:15090): VTE-CRITICAL **: 13:44:32.049: void vte_terminal_match_set_cursor_type(VteTerminal*, int, GdkCursorType): assertion 'tag >= 0' failed

The reason is probably a new version of a dependency (GTK, or VTE to be more precise) combined with some deprecated library usages (see also #106).

There is a bugreport over at debian with some ideas on how to patch this. If anybody has some deeper insights on that part of src/notebook.c, feel free to chime in!

Also not sure if latest master has this fixed already, i will try to verify this. Ubuntu 20.10 currently ships 0.9.9.4+git20150208.f600c0-5.

For distros to pick this up, a new release tag (see #116) would probably be helpful.

[x29a]

Ok, after building master with (from within the sourcecode folder)

$ docker run -t -i -v ${PWD}:/src tecnickcom/alldev /bin/bash
$ cd src
$ apt update && apt install -y libvte-dev
$ ./autogen.sh
$ make

i can verify that lilyterm starts up correctly. So just an issue of that old version distributed with distros.

20220725 edit: i had to remove the -Werror in the src/Makefile file in order to compile from source despite the deprecation warnings being treated as errors:

CFLAGS ?= -Wall -Os