Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aminoAcidToDegenerateDnaMap.js is using a RNA map for converting AA sequence to DNA sequence #195

Closed
XingGao-PKI opened this issue Sep 15, 2021 · 2 comments

Comments

@XingGao-PKI
Copy link
Contributor

Hi @tnrich,
I found the Copy DNA BPs functionality is not working correctly, then I did some dig up, found the aminoAcidToDegenerateDnaMap.js file is using a RNA map parsing AA seq to DNA seq. (Should change all u to t). This is not right, could you fix this ?

Also, the R amnio acid should be mgn, rather than mng, could you also fix this?

Or may I submit a PR instead ?

@tnrich

@tnrich
Copy link
Collaborator

tnrich commented Sep 15, 2021

I'd love if you submitted a PR with any appropriate tests! Thanks for looking into this @XingGao-PKI

@XingGao-PKI
Copy link
Contributor Author

Fixed in #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants