Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cell Editing to TRC #289

Closed
35 tasks done
tnrich opened this issue Oct 18, 2022 · 2 comments
Closed
35 tasks done

Add Cell Editing to TRC #289

tnrich opened this issue Oct 18, 2022 · 2 comments
Assignees

Comments

@tnrich
Copy link
Contributor

tnrich commented Oct 18, 2022

Dragging just 1 cell with nothing before it (same as normal):

image

becomes

image

Dragging more than one cell incrementing:
image
becomes
image

Dragging more than one cell incrementing with text and 0 before:
image
becomes
image

Dragging just one cell with increment before:
image
becomes
image

  • make sure comma seperated vals can be pasted in (copied direct from CSV) need to allow for commas in quotes

  • support addition of rows when pasting in data that overflows the bottom of the table

  • validation needs to be rerun for affected rows on paste (not sure why it's not already?) (seems like it is in certain cases --> repro - upload affinity tags csv and copy sequence from type row to another row)

  • make sure download of files from file list is working

  • make sure remove rows works on the last row if it is the only row selected

  • add an Add 10 Rows button to the bottom of the table

    • make sure it still shows up when there is no data
    • make sure it doesn't show up when Show only rows with errors is enabled
  • when deleting rows, validation needs to be removed for those rows

  • add cell selection abilities

  • add click to edit cell

  • add dropdown editable cells

    • dropdown cell should have a little click to edit icon:

image

image

  • add bottom right drag to copy cell to cells below functionality

image

  • make sure bottom right drag works with boolean column

  • add numeric input

  • support paste functionality

  • add column auto validation/formatting

    • drop-down/boolean/numeric column should auto format malformed incoming data

    • malformed data that can't be auto formatted should display as a red cell

    • allow passing additional validation/formatting functions on the column schema

  • dragging the cell drag handle should allow the table to scroll if necessary

  • take out the padding on the dropdown cell when it is in edit mode

  • add a tiny margin right on the table when in cell editing mode to prevent unnecessary horizontal scrollbar when selected (caused by cell dropdown dragger)

  • Support selection of multiple cells

  • support copy of multiple cells

  • support addition of rows

  • start single cell edit on hitting enter

  • do NOT send edit action if no edit was actually made to the cells

  • fix dropdown styling(?) weirdness:
    https://user-images.githubusercontent.com/2730609/199064687-9739bfc4-9769-4a46-8624-fde46d4e1286.mov

  • add cell delete + cell cut functionality

  • add tests for all the above bullet points (where applicable)
    Stretch Goals:

  • allow cell drag to occur across multiple columns if multiple columns are selected in a contiguous group

@tgreen7
Copy link
Contributor

tgreen7 commented Oct 21, 2022

pasting logic:

  1. If there is a single thing in clipboard (no newlines and no tabs), paste that into every selected cell
  2. try to paste in the same layout that the copy was in should match cell to cell where possible in selections. extra cells from copy that are not in new selection will be ignored.
  3. if only a single cell is selected when pasting then the copied format should try to paste all cells in same format until it runs of edge

@tnrich
Copy link
Contributor Author

tnrich commented Nov 18, 2022

Closing this as it has been completed!

@tnrich tnrich closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants