Adding Configurable Display type to Salesforce Auth Request #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Display mode to SalesforceAuthenticationOptions
|
Hi, sorry I havn't seen this PR. I was on vacation when you dropped this, and didn't notice until now. |
TerribleDev
requested changes
Jun 13, 2018
| /// <summary> | ||
| /// Gets or sets the display—(Optional) | ||
| /// </summary> | ||
| public Display DisplayMode { get; set; } |
There was a problem hiding this comment.
Shouldn't This should default to page?
There was a problem hiding this comment.
Display is an enum with Page as the default value - I can make it explicit if you would prefer?
There was a problem hiding this comment.
good to complete PR then?
|
Hi, just one quick code comment if you don't mind... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for change between different display types. Added Enum to handle default, with values as specified here in salesforce docs