Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ModuleTestingEnvironment and CoreAssets dependencies optional #53

Closed
jdrueckert opened this issue May 18, 2020 · 2 comments · Fixed by #89
Closed

Make ModuleTestingEnvironment and CoreAssets dependencies optional #53

jdrueckert opened this issue May 18, 2020 · 2 comments · Fixed by #89
Labels
Good First Issue Good for learners that are new to Terasology

Comments

@jdrueckert
Copy link
Member

Only references to CoreAssets are in tests.
Health has ModuleTestingEnvironment as optional dependency as it's only required for testing (see https://github.com/Terasology/Health/blob/develop/module.txt#L9).
@jdrueckert jdrueckert added the Good First Issue Good for learners that are new to Terasology label May 18, 2020
@gaurav9822
Copy link

@jdrueckert can I take this one?

Also, please mark the repo as "hacktoberfest"

@skaldarnar
Copy link
Contributor

@gaurav9822 please go ahead 👍 Repository now has the "hacktoberfest" topic 🤓

Happy Coding!

@ujjman ujjman mentioned this issue Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for learners that are new to Terasology
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: make CoreAssets dependency optional Terasology/Rails
3 participants
@skaldarnar @gaurav9822 @jdrueckert