Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorldlyToolTip support for Furnishings #16

Open
jdrueckert opened this issue Dec 4, 2021 · 3 comments
Open

Add WorldlyToolTip support for Furnishings #16

jdrueckert opened this issue Dec 4, 2021 · 3 comments
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Improvement Request for or addition/enhancement of a feature

Comments

@jdrueckert
Copy link
Member

jdrueckert commented Dec 4, 2021

WorldlyTooltip currently has support for blocks, players, and WildAnimals: https://github.com/Terasology/WorldlyTooltip#worldlytooltip
However, the items in furnishings (currently doors and trunks) don't qualify as normal blocks, which is why the tooltip does not properly show a name and icon for them:
image

@jdrueckert jdrueckert added Type: Improvement Request for or addition/enhancement of a feature Good First Issue Good for learners that are new to Terasology Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Size: S Small effort likely only affecting a single area and requiring little to no research Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience labels Dec 4, 2021
@abu271
Copy link

abu271 commented Jun 2, 2022

Hi @jdrueckert I am taking a look at this issue, I am new to Java. My question is that when intercepting GetTooltipIconEvent and GetTooltipNameEvent events.

Do I need to use both DoorComponet & TrunkComponent classes for display name and icon?

@jdrueckert
Copy link
Member Author

jdrueckert commented Jun 4, 2022

Hi @abu271
You only need one of them at a time. DoorComponent is present in door entities whereas TrunkComponent is present in trunk entities.

The ReceiveEvent in combination with the specified components has the effect, that the method is only executed if the event occurs for an entity that has the specified component. So if you check for DoorComponent, the method will be executed if the event occurs for a door entity, but not for a trunk. I you check for TrunkComponent, the method will be executed if the event occurs for a trunk entity, but not for a door. If you check for both, then the method will likely never be executed, because there is no entity that has both, a DoorComponent and a TrunkComponent.

Hope that answers the question 🙂

Commit your changes and create a PR as early as possible, then I can provide some more help on the basis of your changes in case you get stuck with something 😉

(also feel free to join our Discord, for potentially less asychronous communication)

@jdrueckert jdrueckert moved this to ✨ Highlighted Improvements in Highlighted Bugs & Gameplay Improvements Aug 27, 2022
@jdrueckert jdrueckert moved this from ✨ Highlighted New Content to ⬆ Highlighted Improvements in Highlighted Bugs & Gameplay Improvements Aug 27, 2022
@jdrueckert jdrueckert moved this from ⬆ Content Improvements to ➡ Next Up in Highlighted Bugs & Gameplay Improvements Aug 27, 2022
@jdrueckert jdrueckert moved this from ➡ Next Up to 📔 Backlog in Highlighted Bugs & Gameplay Improvements Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Improvement Request for or addition/enhancement of a feature
Projects
Status: 📔 Backlog
Development

No branches or pull requests

2 participants