Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk border rendering crashes the game #10

Closed
skaldarnar opened this issue May 30, 2020 · 6 comments
Closed

Chunk border rendering crashes the game #10

skaldarnar opened this issue May 30, 2020 · 6 comments
Labels
Type: Bug Issues reporting and PRs fixing problems

Comments

@skaldarnar
Copy link
Contributor

When in Debug mode F3 and pressing F8 the game should render the chunk borders in a wire frame.

This crashes the game with the following error:

java.lang.NoClassDefFoundError: org/terasology/rendering/AABBRenderer
    at org.terasology.corerendering.rendering.dag.nodes.OpaqueBlocksNode.renderChunkBoundingBox(OpaqueBlocksNode.java:234)
    at org.terasology.corerendering.rendering.dag.nodes.OpaqueBlocksNode.process(OpaqueBlocksNode.java:210)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)
    at org.terasology.rendering.world.WorldRendererImpl.render(WorldRendererImpl.java:370)
    at org.terasology.engine.modes.StateIngame.render(StateIngame.java:206)
    at org.terasology.engine.subsystem.lwjgl.LwjglGraphics.postUpdate(LwjglGraphics.java:166)
    at org.terasology.engine.TerasologyEngine.tick(TerasologyEngine.java:473)
    at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:427)
    at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:403)
    at org.terasology.engine.Terasology.main(Terasology.java:163)

@skaldarnar skaldarnar added the Type: Bug Issues reporting and PRs fixing problems label May 30, 2020
@skaldarnar
Copy link
Contributor Author

This also affects other rendered bounding boxes, like the ones drawn by Structure Templates. It looks like the outlines are drawn to the background instead of augmenting the world around the player.

image

@kBlaszczyk
Copy link
Contributor

kBlaszczyk commented Jun 8, 2020

I think that the class AABBRenderer would need to be annotated with @API to be available to modules at runtime. Unfortunately that doesn't solve the problem...
I had to recache the reflections, adding @API to AABBRenderer does solve the issue.

@Cervator
Copy link
Member

Closing as fixed by MovingBlocks/Terasology#4042, confirmed locally - thanks @kBlaszczyk ! :-)

@skaldarnar
Copy link
Contributor Author

Does that also fix the preview rendering of structure templates? If nobody beats me to it, I'll check that later today...

@kBlaszczyk
Copy link
Contributor

That's most likely unrelated. It looks like a rendering order issue. Maybe the environment is rendered after the bounding boxes, with a cleared depth buffer. So you can only see the bounding boxes where nothing else was drawn over them.
Deserves it's own issue I think.

@Cervator
Copy link
Member

I think that's been a separate issue for a while yeah :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

No branches or pull requests

3 participants