-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to sort nested columns #593
Comments
Absolutely a feature request and not a bug since nested columns isn't intended, but we'd like to see your first draft in a PR to consider the feature. Not sure how or when we're approaching the complexity of nested hierarchy since it makes sorting, selection, pagination, filtering, etc, vastly more complex |
It looks like nested columns were intended. The _getNestedColumn function was specifically created for that purpose. What would be the problem with using that function for sorting ? |
Did Teradata Covalent ever provide the ability to sort nested row data? I am using the data-table atomic components, and I have updated to the newest version of Teradata (1.0.0-beta.8-1) and of Angular Material (2.0.0-beta.12). The data I am using to populate my rows comes in an array looking like this: Thank you in advance. |
Do you want to request a feature or report a bug?
feature
Feature Request
Sorting nested columns is not possible with
DataTableService.sortData
due to its implementation, specifically this line https://github.com/Teradata/covalent/blob/develop/src/platform/core/data-table/services/data-table.service.ts#L45http://plnkr.co/edit/3oEaTBkpGjkWrdpEHinJ?p=preview
column
BAR.BAZ
is not getting sortedWhat is the expected behavior?
DataTableService.sortData
should work with nested columnsWhat is the motivation / use case for changing the behavior?
Maping data to flat structure is annoying. Using custom sort method feels like working against the library.
Which version of Angular and Material, and which browser and OS does this issue affect?
@angular/core
4.1.2@angualr/material
2.0.0-beta.3@covalent/core
1.0.0-beta.3-2Did this work in previous versions of Angular / Material?
No
Other information
_getNestedValue
ofTdDataTableComponent
could be moved to theTdDataTableService
and used toget correct value.
I'm willing to send PR for this
The text was updated successfully, but these errors were encountered: