-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Messaging component #316
Comments
Referencing this #256 since its related |
Let's iterate on the API requirements: API Summary
|
To allow more flexibly, lets make the actions something the user can add as needed (possibly):
Unless we wanna stick with 1 behavior and just replace the text |
An attribute showing
|
Referencing prime ng messages: http://www.primefaces.org/primeng/#/messages |
We should always render a card with toolbar (icon/title/close). No card title/subtitle API
|
Super happy with the progress and UX now. Gonna dig into code review |
Component property bindings /**
* messageTitle: string
*
* The title set in toolbar.
*/
@Input() messageTitle: string;
/**
* messageSubtitle?: string
*
* Optional second line subhead set in toolbar.
*/
@Input() messageSubtitle: string;
/**
* icon: string
*
* The icon name to be displayed before the title.
* Defaults to info_outline icon
*/
@Input() icon: string = 'info_outline';
/**
* color?: string
*
* The optional toolbar color.
*/
@Input() color: string = 'none';
/**
* close: string
*
* The clear icon for hiding message.
* Defaults to clear icon "x"
*/
@Input() close: string = 'clear';
/**
* message?: string
*
* The optional string content of the message body.
*/
@Input() message: string;
/**
* actionPrimary?: string
*
* The optional url or route for primary action button in card footer.
*/
@Input() actionPrimary: string;
/**
* actionSecondary?: string
*
* The optional url or route for secondary (accent) action button in card footer.
*/
@Input() actionSecondary: string; |
Im good with that as a starting base. We still need to revisit the buttons though.. since people might want to set their own buttons for other stuff rather than routing, and an |
Also, it might make more sense to be able to set the message this way too. <td-message>
{{message}}
//Additional content also accepted.
</td-message> OR <td-message [message]="message"></td-message> As an alternative, and have a quick API (easy) to set it too. |
Funny fact is that I was about to suggest this as a feature for covalent. Currently Im using angular2-notifications in my project. If something similar could be integrated into covalent it would be awesome. |
@jotatoledo notifications is more like material snackbar/toast (they'll be adding more features like the one you're using) https://material.angular.io/components/component/snack-bar This messages component was being designed for in-page alerts, more like https://v4-alpha.getbootstrap.com/components/alerts/ |
Would love to see this soon. |
We are polishing this in one of our products and planning on adding it soon 😄 |
@emoralesb05 Will this be part of beta.4 or will this be delayed to the next beta/rc? |
Plans are to include it in |
This will be included with #596 😄 |
Do you want to request a feature or report a bug?
Feature
Feature Request
Messaging component for info, alerts, warnings, errors, and successes.
Screenshots or link to CodePen/Plunker/JSfiddle
Examples:


What is the expected behavior?
Component should have the ability to implement color and icon style in the template.
What is the motivation / use case for changing the behavior?
Create and standardize patterns for surfacing relevant and timely information to the user.
Other information
Material design patterns for errors: https://material.io/guidelines/patterns/errors.html
Material design patterns for notifications: https://material.io/guidelines/patterns/notifications.html
The text was updated successfully, but these errors were encountered: