Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed with type error. #236

Closed
ajmal-shah opened this issue Jan 4, 2017 · 5 comments
Closed

Build failed with type error. #236

ajmal-shah opened this issue Jan 4, 2017 · 5 comments
Labels
Milestone

Comments

@ajmal-shah
Copy link

Bug Report

ERROR in [at-loader] node_modules@covalent\core\file\directives\file-drop.directive.ts:84:43
Argument of type 'string[]' is not assignable to parameter of type 'DOMStringList'.
Property 'contains' is missing in type 'string[]'.

Which version of Angular and Material, and which browser and OS does this issue affect?

@covalent/core : 0.10.2
typescript version 2.1.4
webpack version 1.14.0

Did this work in previous versions of Angular / Material?
*Covalent/core worked with previous versions.
*CovalentFileModule was an independent module till covalent 0.9.0 (@covalent/file-upload) . *@covalent/core : 0.10.2 build fails with the error.

@emoralesb05
Copy link
Contributor

emoralesb05 commented Jan 4, 2017

How do you have your tsconfig.json configured?

Trying to replicate it, but cant seem to do so.. any additional information you have would be much appreciated.

@ajmal-shah
Copy link
Author

Here is the tsconfig file content.

{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"moduleResolution": "node",
"sourceMap": true,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"removeComments": false,
"noImplicitAny": true,
"baseUrl": "./src",
"suppressImplicitAnyIndexErrors": true,
"exclude": [
"node_modules",
"dist"
],
"awesomeTypescriptLoaderOptions": {
"forkChecker": true,
"useWebpackText": true
}
}
}

@kyleledbetter
Copy link
Contributor

i might be out of my depth but this is what we have in covalent-quickstart

{
  "compileOnSave": false,
  "compilerOptions": {
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "mapRoot": "./",
    "lib": ["es6", "dom"],
    "module": "es6",
    "moduleResolution": "node",
    "outDir": "../dist/out-tsc",
    "sourceMap": true,
    "target": "es5",
    "typeRoots": [
      "../node_modules/@types"
    ],
    "types": [
      "jasmine", "hammerjs"
    ]
  }
}

@emoralesb05
Copy link
Contributor

Yeah, please try using the same config as us. Most of the angular/angular@material repos use that same config for lib.

"lib": ["es6", "dom"],

e.g.
https://github.com/jelbourn/material2-app/blob/master/src/tsconfig.json

@emoralesb05
Copy link
Contributor

emoralesb05 commented Jan 5, 2017

Ok, manage to replicate it.. its a problem when upgrading to [email protected].
microsoft/TypeScript#12069
angular/angular-cli#3157

We are still on 2.0.10 because there were known issues in 2.1.x. We will start testing on 2.1.4 asap, but for now i would just go back to 2.0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants