Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Material icon Font #196

Closed
John0x opened this issue Dec 15, 2016 · 2 comments
Closed

Remove Material icon Font #196

John0x opened this issue Dec 15, 2016 · 2 comments

Comments

@John0x
Copy link

John0x commented Dec 15, 2016

I believe it would be better to remove the Material Icon font from the platform.css and do it like Material 2 (include <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet"> in the html).

Trying to use Covalent with an existing webpack build system is not that nice because the font cannot be loaded properly.

@kyleledbetter
Copy link
Contributor

hmmm, one of the main reasons we built Covalent was to make using Angular-Material easier to use with everything an app needs out of the box...like not having to include the font separately...

I think your point is valid but instead we need to focus on better manual inclusion docs so you can easily cherrypick covalent modules

@emoralesb05
Copy link
Contributor

If you are using webpack without the angular-cli then you need to configure it to load the fonts.

https://shellmonger.com/2016/01/22/working-with-fonts-with-webpack/

Basically add a loader for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants