Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CovalentFileModule missing @NgModule annotation in 1.0.0-rc.3 #1100

Closed
galtalmor opened this issue Jan 23, 2018 · 2 comments
Closed

CovalentFileModule missing @NgModule annotation in 1.0.0-rc.3 #1100

galtalmor opened this issue Jan 23, 2018 · 2 comments

Comments

@galtalmor
Copy link

galtalmor commented Jan 23, 2018

Do you want to request a feature or report a bug?

Bug

Bug Report

Screenshots or link to CodePen/Plunker/JSfiddle

This is what happens when I run ng build --prod. Which worked just fine with Covalent 1.0.0-rc.1, but once I upgrade to Covalent 1.0.0-rc.3 it stops working.
image

What is the expected behavior?

Successful build when using CovalentFileModule

What is the motivation / use case for changing the behavior?

Successful build when using CovalentFileModule

Which version of Angular and Material, and which browser and OS does this issue affect?

Angular 5.2.1
Material 5.1.0
Win 10
Chrome 63

Did this work in previous versions of Angular / Material?
It worked with older version of Covalent (1.0.0-rc.1).
Doesn't work with and version of Angular/Material with Covalent 1.0.0-rc.3

Other information

I tried both importing CovalentFileModule from @covalent/core and @covalent/core/file. Same result.
I suppose someone just removed/forgot to put @ngModule by mistake.

@emoralesb05
Copy link
Contributor

Closing since its a dupe of #1099

We will track the progress in the other one

@galtalmor
Copy link
Author

Sorry, it didn't show up when I searched for the issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants