Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdLoading uses wrong height if element is hidden when initialized #1045

Closed
freastro opened this issue Dec 15, 2017 · 0 comments · Fixed by #1066
Closed

tdLoading uses wrong height if element is hidden when initialized #1045

freastro opened this issue Dec 15, 2017 · 0 comments · Fixed by #1066

Comments

@freastro
Copy link
Member

Bug Report

I tried using tdLoading on an icon within a notification menu to indicate a process that was ongoing. Since the element was hidden when tdLoading was initialized, it used the default height of 100px instead of waiting for the element to become visible. The effect is that the progress spinner is too large for the icon.

Screenshots or link to CodePen/Plunker/JSfiddle

https://covalent-pt5ucb.stackblitz.io

What is the expected behavior?

tdLoading should wait for the element's height to become known or monitor the element's height for changes. Then adjust the progress spinner height as necessary.

What is the motivation / use case for changing the behavior?

Ability to use tdLoading on an icon within a menu.

Which version of Angular and Material, and which browser and OS does this issue affect?

Covalent 1.0.0-rc.1 with Angular 5 and Material 5 on macOS Sierra with Google Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants